fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
Date Sun, 08 Mar 2020 12:18:34 GMT
vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of
Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r389363723
 
 

 ##########
 File path: fineract-provider/src/main/resources/META-INF/spring/jndi.xml
 ##########
 @@ -29,6 +29,12 @@
     	http://www.springframework.org/schema/jee http://www.springframework.org/schema/jee/spring-jee-3.0.xsd">
 
 	<!-- name here must match TestDataSourceConfiguration -->
-	<jee:jndi-lookup jndi-name="java:comp/env/jdbc/mifosplatform-tenants"
-		id="tenantDataSourceJndi" />
+
+    <bean id="tenantDataSourceJndi" 
 
 Review comment:
   It would be clearer to rename this bean name and drop the *Jndi suffix (because not it's
not using JNDI anymore...), and according change the use of this bean in the code (search
for it...).  Also, it then probably should not be in `jndi.xml` anymore now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message