From commits-return-7337-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Feb 2 10:36:32 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BBCEB1802C7 for ; Sun, 2 Feb 2020 11:36:31 +0100 (CET) Received: (qmail 97863 invoked by uid 500); 2 Feb 2020 10:36:30 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 97850 invoked by uid 99); 2 Feb 2020 10:36:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Feb 2020 10:36:30 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #707: FINERACT-775 Clean up Util Message-ID: <158063979063.16811.6720386158076606660.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 02 Feb 2020 10:36:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #707: FINERACT-775 Clean up Util URL: https://github.com/apache/fineract/pull/707#discussion_r373835403 ########## File path: fineract-provider/src/test/java/org/apache/fineract/common/Utils.java ########## @@ -28,13 +28,11 @@ import com.jayway.restassured.path.json.JsonPath; import com.jayway.restassured.specification.RequestSpecification; import com.jayway.restassured.specification.ResponseSpecification; -import java.text.ParseException; -import java.text.SimpleDateFormat; -import java.util.Locale; -import java.util.Random; import org.apache.commons.lang.StringUtils; import org.apache.http.conn.HttpHostConnectException; + + /** * Util for RestAssured tests. This class here in src/test is copy/pasted :( * from and identical to the one in src/integrationTest; please keep it in sync. Review comment: @percyashu do you want to do the same clean up in the same class in src/integrationTest as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services