fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #72: fix: Improve search feature in Customer Fragment
Date Wed, 26 Feb 2020 09:29:15 GMT
jawidMuhammadi commented on a change in pull request #72: fix: Improve search feature in Customer
Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#discussion_r384369158
 
 

 ##########
 File path: app/src/main/java/org/apache/fineract/ui/online/customers/customerlist/CustomersFragment.java
 ##########
 @@ -271,14 +271,15 @@ private void setUpSearchInterface(Menu menu) {
         searchView.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
             @Override
             public boolean onQueryTextSubmit(String query) {
-                findCustomer(query);
                 return false;
             }
 
             @Override
             public boolean onQueryTextChange(String newText) {
                 if (TextUtils.isEmpty(newText)) {
                     customerAdapter.setCustomers(customers);
+                } else {
+                   findCustomer(newText);
 
 Review comment:
   Here you have check style violation. You have added 1 more space on line number 283.
   How to solve it?
   Go to your CustomersFragment.java file enter `Ctr+Alt+SPACE`. It will solve the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message