fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror opened a new pull request #710: FINERACT-807 - Use underscore instead of dash in tenants and default tenant database names
Date Fri, 14 Feb 2020 06:58:26 GMT
xurror opened a new pull request #710: FINERACT-807  -  Use underscore instead of dash in tenants
and default tenant database names
URL: https://github.com/apache/fineract/pull/710
 
 
   ## Description
   The Fineract tenants and tenant database names by default are currently mifosplatform-tenants
and mifostenant-default respectively.
   
   The Google Cloud Platform console for managed MySQL (Cloud SQL) prevents creating MySQL
databases containing dashes; the UI says Database name: Needs to follow the MySQL identifier
rules.
   
   While this limitation appears to only be enforced in the Google Cloud UI (it's still possible
to create databases containing '-' dashes using the gcloud CLI), the linked doc does seem
to suggest to use only underscores.
   
   To make this simpler, and comply with mySQL doc recommendation, let's change mifosplatform-tenants
to fineract_tenants and mifostenant-default to fineract_default. (The change from mifosplatform
to fineract is just because this seems a good opportunity to make that change, and because
it's probably less and not more confusing to change the entire name, and not just a dash to
and underscore.)
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message