fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger opened a new pull request #703: Activate and Enforce Checkstyle EqualsHashCode check.
Date Mon, 27 Jan 2020 20:18:56 GMT
vorburger opened a new pull request #703: Activate and Enforce Checkstyle EqualsHashCode check.
URL: https://github.com/apache/fineract/pull/703
 
 
   Thanks to prior work for SpotBugs, this passes without requiring any
   code adjustments.  (Fineract had a nubmer of problems in this space
   before the SpotBugs work.)
   
   Enabling this helps to ensure non-regression so that no new equals() and
   hashCode() related bugs creep in.  (This does overlap a little bit with
   SpotBugs, but the build time overhead to run the extra check is
   completely negligible, so it seems worth having this.  If only just in
   case SpotBugs for whatever reason in the future would get deactivated
   again.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message