fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger opened a new pull request #690: fix broken docker-compose set up (re. FINERACT-773)
Date Sun, 12 Jan 2020 19:44:39 GMT
vorburger opened a new pull request #690: fix broken docker-compose set up (re. FINERACT-773)
URL: https://github.com/apache/fineract/pull/690
 
 
   This fixed bugs introduced in edc9e030e10b9f7f6c394ab35c307c7fa28939a0
   (in https://github.com/apache/fineract/pull/648) which for FINERACT-773
   actually broke things more instead of adding the intended feature, cauz:
   
   1. FINERACT_DEFAULT_TENANTDB_HOSTNAME and FINERACT_DEFAULT_TENANTDB_PORT
      were meant to be OS Environment Variables, not Java System properties
      and so need to be read via System.getenv() not System.getProperty(),
      duh!
   
   2. The Travis CI test which was meant to ensure non-regression for this
      broke in that same change, because the "|| docker logs" introduced at
      the same time would always pass (EITHER because "http" passed OR
      if not then "docker logs" would return 0), duh again!
   
   Both were dumb, not sure what I was thinking when I had hacked this.. ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message