fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] angelboxes opened a new pull request #683: FINERACT-824: NullPointerException is thrown when submitting a loan account application with an existing externalId
Date Fri, 10 Jan 2020 21:17:14 GMT
angelboxes opened a new pull request #683: FINERACT-824: NullPointerException is thrown when
submitting a loan account application with an existing externalId
URL: https://github.com/apache/fineract/pull/683
 
 
   Removed the second validation since realCause.getCause() is null if it is equal to realCause
   
   ## Description
   When I tried to create a new loan account with an already used external Id, a NullPointerException
was thrown with no description of why the loan account creation failed. I removed a validation
that returned a null value, this kind of validation was only used with integrity issues on
loan accounts and added for some OpenJPA Integration Changes. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message