fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on issue #704: Activate and Enforce new Checkstyle check related to import statement order (FINERACT-821)
Date Mon, 27 Jan 2020 22:10:59 GMT
awasum commented on issue #704: Activate and Enforce new Checkstyle check related to import
statement order (FINERACT-821)
URL: https://github.com/apache/fineract/pull/704#issuecomment-578979362
 
 
   > @awasum hey how do you like this? 
   > 
   > FYI full disclosure  you actually motivated me to finally do this, because I noticed
while I was just reviewing your #701 earlier again that in many PRs in this project there
are always a bunch of import order related changes, not specific to upgrading e.g. Spring
Boot or whatever the PR is about (I've run into this in other PRs in the past). In other projects
I'm used to working on, this is a total non-issue, because...
   > 
   
   Super useful, I use IntelliJ from Jetbrains. I usually natural use Optimize Import (CTRL
+ ALT + O) whenever I finish working with a class each time. I dont know how I developed that
instinct...Maybe I saw it somewhere in open source and it clicked. 
   
   For something which enforces this Import Optimization rule, do you know if we could get
somethign similar for IntelliJ (a EPF compatible) type of config for Fineract on IntelliJ
to enforce our preferences.
   Is that even something of value to the project? Probably not. And is something which should
not really go with this PR.
   
   Once this passes Travis, I will just merge it, as long as am not asleep by then..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message