fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #704: Activate and Enforce new Checkstyle check related to import statement order (FINERACT-821)
Date Mon, 27 Jan 2020 21:48:45 GMT
vorburger commented on issue #704: Activate and Enforce new Checkstyle check related to import
statement order (FINERACT-821)
URL: https://github.com/apache/fineract/pull/704#issuecomment-578970108
 
 
   @awasum hey how do you like this? :smiling_imp: 
   
   FYI full disclosure :smile_cat:  you actually motivated me to finally do this, because
I noticed while I was just reviewing your #701 earlier again that in many PRs in this project
there are always a bunch of import order related changes, not specific to upgrading e.g. Spring
Boot or whatever the PR is about (I've run into this in other PRs in the past). In other projects
I'm used to working on, this is a total non-issue, because...
   
   ... in my experience, fixing an import order convention (any one, in the end it does not
really matter which one; this one IMHO is just simply the most simple and logical one, even
if it takes a second to get used to it, but then it feels natural), then doing a bulk re-ordering
once, and from then onwards enforcing it (which this also does), and... bingo - no more arbitrary
import order changes in PRs! (Because people have to fix them, otherwise their PR's build
fails.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message