fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #698: FINERACT-806 - Allow customizing Tenants JDBC password, username and driverClassName (not just URL)
Date Sun, 26 Jan 2020 11:12:51 GMT
vorburger commented on a change in pull request #698: FINERACT-806 - Allow customizing Tenants
JDBC password, username and driverClassName (not just URL)
URL: https://github.com/apache/fineract/pull/698#discussion_r370990663
 
 

 ##########
 File path: docker/server.xml
 ##########
 @@ -43,8 +43,8 @@
         factory="org.apache.tomcat.jdbc.pool.DataSourceFactory"
         driverClassName="org.drizzle.jdbc.DrizzleDriver"
         url="${fineract_tenants_url}"
-        username="root"
-        password="mysql"
+        username="${username}"
+        password="${password}"
 
 Review comment:
   Please use ’fineract_tenants_uid’ (and _pwd) instead of "username" and "password",
to make more clear what these system properties are for.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message