fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #680: Fixing bulk import integration test failures
Date Thu, 23 Jan 2020 18:30:51 GMT
vorburger commented on issue #680: Fixing bulk import integration test failures
URL: https://github.com/apache/fineract/pull/680#issuecomment-577812669
 
 
   > isn't an Assertion statement at line 143 nor 
   
   indeed the only assertion around there is the `Assert.assertNotNull(importDocumentId);`
which is in line 145 not 143... I would just assume it's that one that's failing here (just
because there is no other one), and not loose too much sleep about that (slight) line number
mismatch. I can't quite explain it either, but if you made me guess, I would suspect it may
be related to and may just have been solved by (my) recent #688 re. CR/LF... you could rebase
to the latest develop, to check. If it's still a little bit off, just assume it's that one,
and try to fix that.
   
   > need to have the complete stacktrace of the AssertionError. 
   
   Travis unfortunately doesn't let you see it, what we do is locally reproduce and debug.
   
   > I'm able recreate this locally on my end.
   
   But are you really running `./gradlew integrationTest` (not just `test` or `build`) ? 
I'm pretty sure you should locally hit it as well... unless this is some mess due to time
zone or something, but that seems quite unlikely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message