fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #696: FINERACT-839: NPE when creating a Loan for a client fix
Date Thu, 23 Jan 2020 17:57:45 GMT
vorburger commented on issue #696: FINERACT-839: NPE when creating a Loan for a client fix
URL: https://github.com/apache/fineract/pull/696#issuecomment-577796737
 
 
   > What is wron with instead of returning Null we instead do ` return Boolean.FALSE;`,
will this still cause issues?
   
   That's what I would have suggested as well... have commented in FINERACT-839. 
   
   @adamsaghy are you motivated to raise a follow-up PR for that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message