fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on issue #696: FINERACT-839: NPE when creating a Loan for a client fix
Date Thu, 23 Jan 2020 12:40:44 GMT
awasum commented on issue #696: FINERACT-839: NPE when creating a Loan for a client fix
URL: https://github.com/apache/fineract/pull/696#issuecomment-577664780
 
 
   > From business perspective it is different to return FALSE or NULL. I reckon there
was a consideration to choose Boolean as object to make it able to return NULL.
   > 
   > A warning would be better.
   
   Ok...In your PR..Suppress spotbugs for the methods having the error..Just above it, place
the statement: `@FindBugsSuppressWarnings("NP_BOOLEAN_RETURN_NULL")` and spotbug check will
ignore it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message