fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-lang] aasaru commented on a change in pull request #13: Updated to spring boot 2
Date Wed, 22 Jan 2020 14:36:52 GMT
aasaru commented on a change in pull request #13: Updated to spring boot 2
URL: https://github.com/apache/fineract-cn-lang/pull/13#discussion_r369593106
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -15,44 +15,32 @@
  * limitations under the License.
  */
 
-buildscript {
-    repositories {
-        jcenter()
-    }
-
-    dependencies {
-        classpath 'nl.javadude.gradle.plugins:license-gradle-plugin:0.10.0'
-        classpath ("org.ajoberstar:grgit:2.0.0")
-    }
-}
-
 plugins {
-    id 'com.github.hierynomus.license' version '0.13.1'
-    id("org.nosphere.apache.rat") version "0.3.1"
-    id "com.jfrog.artifactory" version "4.9.5"
-    id "io.spring.dependency-management" version "1.0.8.RELEASE"
+    id 'com.github.hierynomus.license' version '0.15.0'
+    id 'org.nosphere.apache.rat' version "0.5.2"
+    id "com.jfrog.artifactory" version "4.11.0"
+    id "org.ajoberstar.grgit" version "4.0.1"
+    id "io.spring.dependency-management" version "1.0.9.RELEASE"
     id 'maven-publish'
-    id 'java'
+    id 'java-library'
     id 'idea'
 }
 
-apply plugin: "org.ajoberstar.grgit"
-
 ext {
     versions = [
-            springcontext        : '4.3.3.RELEASE',
-            springboot           : '1.4.1.RELEASE',
-            findbugs             : '3.0.1'
+            springcontext: '5.2.3.RELEASE',
+            springboot   : '2.2.4.RELEASE',
+            findbugs     : '3.0.2'
     ]
     changesetId = grgit.head().id
 }
 
 group 'org.apache.fineract.cn'
-version '0.1.0-BUILD-SNAPSHOT'
+version 'spring_boot_2-SNAPSHOT'
 
 tasks.withType(JavaCompile) {
-    sourceCompatibility = JavaVersion.VERSION_1_8
-    targetCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_13
+    targetCompatibility = JavaVersion.VERSION_13
 
 Review comment:
   Why you want to upgrade Java version?
   Anyone currently using Fineract-CN is running it on Java8 (as Spring Boot 1.x doesn't work
above Java 8). Why you want them to make two big changes at the same time. Let's only upgrade
Spring & Spring Boot in this iteration and let's leave upgrading everything else to the
future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message