fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
Date Sun, 19 Jan 2020 13:53:59 GMT
vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r368295849
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/self/shareaccounts/api/SelfShareAccountsApiResource.java
 ##########
 @@ -139,7 +152,11 @@ public String createAccount(final String apiRequestBodyAsJson) {
 	@Path("{accountId}")
 	@Consumes({ MediaType.APPLICATION_JSON })
 	@Produces({ MediaType.APPLICATION_JSON })
-	public String retrieveShareAccount(@PathParam("accountId") final Long accountId, @Context
final UriInfo uriInfo) {
+	/*
+    @ApiOperation(value = "Retrieve a share application/account", httpMethod = "GET", notes
= "\n" +
+            "\n" + "\n" + "Example Requests:\n" + "\n" + "self/shareaccounts/12\n")
+    @ApiResponses({@ApiResponse(code = 200, message = "OK", responseContainer = "List", response
 SelfShareAccountsApiResourceSwagger.GetShareAccountResponse.class)})*/
 
 Review comment:
   @Sanyam96 FYI I've fixed this one in my swagger-squash branch which I'll merge ASAP as
much as possible. @kangbreder the problem is that SelfShareAccountsApiResourceSwagger.GetShareAccountResponse
seems to be missing- would you like to raise a small new PR just adding that and fixing this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message