fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] aimanoj commented on a change in pull request #664: FINERACT-802-restrict-client-to-have-single-self-service-user
Date Tue, 14 Jan 2020 10:01:52 GMT
aimanoj commented on a change in pull request #664: FINERACT-802-restrict-client-to-have-single-self-service-user
URL: https://github.com/apache/fineract/pull/664#discussion_r357360518
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/AppUserWritePlatformServiceJpaRepositoryImpl.java
 ##########
 @@ -349,6 +349,10 @@ private void handleDataIntegrityIssues(final JsonCommand command, final
Throwabl
                     username);
         }
 
+        if (realCause.getMessage().contains("'unique_self_client'")) {
 
 Review comment:
   To avoid this type of check inside the exception block, we may have to query the db separately
for the unique check. I feel that would be more intensive than `if` logic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message