fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #680: Fixing bulk import integration test failures
Date Sun, 12 Jan 2020 18:57:19 GMT
vorburger commented on a change in pull request #680: Fixing bulk import integration test failures
URL: https://github.com/apache/fineract/pull/680#discussion_r365603195
 
 

 ##########
 File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
 ##########
 @@ -64,92 +64,99 @@ public void setup() {
     }
 
     @Test
-    @Ignore
-    public void testSavingsImport() throws InterruptedException, IOException, ParseException
{
-
-        requestSpec.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON);
-        //in order to populate helper sheets
-        OfficeHelper officeHelper=new OfficeHelper(requestSpec,responseSpec);
-        Integer outcome_office_creation=officeHelper.createOffice("02 May 2000");
-        Assert.assertNotNull("Could not create office" ,outcome_office_creation);
-
-        //in order to populate helper sheets
-        ClientHelper clientHelper=new ClientHelper(requestSpec,responseSpec);
-        Integer outcome_client_creation=clientHelper.createClient(requestSpec,responseSpec);
-        Assert.assertNotNull("Could not create client" ,outcome_client_creation);
-
-        //in order to populate helper sheets
-        GroupHelper groupHelper=new GroupHelper(requestSpec,responseSpec);
-        Integer outcome_group_creation=groupHelper.createGroup(requestSpec,responseSpec,true);
-        Assert.assertNotNull("Could not create group" ,outcome_group_creation);
-
-        //in order to populate helper sheets
-        StaffHelper staffHelper=new StaffHelper();
-        Integer outcome_staff_creation =staffHelper.createStaff(requestSpec,responseSpec);
-        Assert.assertNotNull("Could not create staff",outcome_staff_creation);
-
-        SavingsProductHelper savingsProductHelper=new SavingsProductHelper();
-        String jsonSavingsProduct=savingsProductHelper.build();
-        Integer outcome_sp_creaction=savingsProductHelper.createSavingsProduct(jsonSavingsProduct,requestSpec,responseSpec);
-        Assert.assertNotNull("Could not create Savings product",outcome_sp_creaction);
-
-        SavingsAccountHelper savingsAccountHelper=new SavingsAccountHelper(requestSpec,responseSpec);
-        Workbook workbook=savingsAccountHelper.getSavingsWorkbook("dd MMMM yyyy");
-
-        //insert dummy data into Savings sheet
-        Sheet savingsSheet = workbook.getSheet(TemplatePopulateImportConstants.SAVINGS_ACCOUNTS_SHEET_NAME);
-        Row firstSavingsRow=savingsSheet.getRow(1);
-        Sheet officeSheet=workbook.getSheet(TemplatePopulateImportConstants.OFFICE_SHEET_NAME);
-        firstSavingsRow.createCell(SavingsConstants.OFFICE_NAME_COL).setCellValue(officeSheet.getRow(1).getCell(1).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.SAVINGS_TYPE_COL).setCellValue("Individual");
-        firstSavingsRow.createCell(SavingsConstants.CLIENT_NAME_COL).setCellValue(savingsSheet.getRow(1).getCell(SavingsConstants.LOOKUP_CLIENT_NAME_COL).getStringCellValue());
-        Sheet savingsProductSheet=workbook.getSheet(TemplatePopulateImportConstants.PRODUCT_SHEET_NAME);
-        firstSavingsRow.createCell(SavingsConstants.PRODUCT_COL).setCellValue(savingsProductSheet.getRow(1).getCell(1).getStringCellValue());
-        Sheet staffSheet=workbook.getSheet(TemplatePopulateImportConstants.STAFF_SHEET_NAME);
-        firstSavingsRow.createCell(SavingsConstants.FIELD_OFFICER_NAME_COL).setCellValue(staffSheet.getRow(1).getCell(1).getStringCellValue());
-        SimpleDateFormat simpleDateFormat=new SimpleDateFormat("dd MMMM yyyy");
-        Date date=simpleDateFormat.parse("13 May 2017");
-        firstSavingsRow.createCell(SavingsConstants.SUBMITTED_ON_DATE_COL).setCellValue(date);
-        firstSavingsRow.createCell(SavingsConstants.APPROVED_DATE_COL).setCellValue(date);
-        firstSavingsRow.createCell(SavingsConstants.ACTIVATION_DATE_COL).setCellValue(date);
-        firstSavingsRow.createCell(SavingsConstants.CURRENCY_COL).setCellValue(savingsProductSheet.getRow(1).getCell(10).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.DECIMAL_PLACES_COL).setCellValue(savingsProductSheet.getRow(1).getCell(11).getNumericCellValue());
-        firstSavingsRow.createCell(SavingsConstants.IN_MULTIPLES_OF_COL).setCellValue(savingsProductSheet.getRow(1).getCell(12).getNumericCellValue());
-        firstSavingsRow.createCell(SavingsConstants.NOMINAL_ANNUAL_INTEREST_RATE_COL).setCellValue(savingsProductSheet.getRow(1).getCell(2).getNumericCellValue());
-        firstSavingsRow.createCell(SavingsConstants.INTEREST_COMPOUNDING_PERIOD_COL).setCellValue(savingsProductSheet.getRow(1).getCell(3).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.INTEREST_POSTING_PERIOD_COL).setCellValue(savingsProductSheet.getRow(1).getCell(4).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.INTEREST_CALCULATION_COL).setCellValue(savingsProductSheet.getRow(1).getCell(5).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.INTEREST_CALCULATION_DAYS_IN_YEAR_COL).setCellValue(savingsProductSheet.getRow(1).getCell(6).getStringCellValue());
-        firstSavingsRow.createCell(SavingsConstants.MIN_OPENING_BALANCE_COL).setCellValue(1000.0);
-        firstSavingsRow.createCell(SavingsConstants.LOCKIN_PERIOD_COL).setCellValue(1);
-        firstSavingsRow.createCell(SavingsConstants.LOCKIN_PERIOD_FREQUENCY_COL).setCellValue("Weeks");
-        firstSavingsRow.createCell(SavingsConstants.APPLY_WITHDRAWAL_FEE_FOR_TRANSFERS).setCellValue("False");
-        firstSavingsRow.createCell(SavingsConstants.ALLOW_OVER_DRAFT_COL).setCellValue("False");
-        firstSavingsRow.createCell(SavingsConstants.OVER_DRAFT_LIMIT_COL).setCellValue(savingsProductSheet.getRow(1).getCell(15).getNumericCellValue());
-
-        String currentdirectory = new File("").getAbsolutePath();
-        File directory=new File(currentdirectory+File.separator+"src"+File.separator+"integrationTest"+File.separator+
-                "resources"+File.separator+"bulkimport"+File.separator+"importhandler"+File.separator+"savings")
;
-        if (!directory.exists())
-            directory.mkdirs();
-        File file= new File(directory+File.separator+"Savings.xls");
-        OutputStream outputStream=new FileOutputStream(file);
-        workbook.write(outputStream);
-        outputStream.close();
-
-        String importDocumentId=savingsAccountHelper.importSavingsTemplate(file);
-        file.delete();
-        Assert.assertNotNull(importDocumentId);
-
-        //Wait for the creation of output excel
-        Thread.sleep(10000);
-
-        //check status column of output excel
-        String location=savingsAccountHelper.getOutputTemplateLocation(importDocumentId);
-        FileInputStream fileInputStream = new FileInputStream(location);
-        Workbook Outputworkbook=new HSSFWorkbook(fileInputStream);
-        Sheet OutputSavingsSheet = Outputworkbook.getSheet(TemplatePopulateImportConstants.SAVINGS_ACCOUNTS_SHEET_NAME);
-        Row row= OutputSavingsSheet.getRow(1);
-        Assert.assertEquals("Imported",row.getCell(SavingsConstants.STATUS_COL).getStringCellValue());
+    public void testSavingsImport() throws InterruptedException, IOException, ParseException,AssertionError
{
+        try {
+            requestSpec.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON);
+            //in order to populate helper sheets
+            OfficeHelper officeHelper = new OfficeHelper(requestSpec, responseSpec);
+            Integer outcome_office_creation = officeHelper.createOffice("02 May 2000");
+            Assert.assertNotNull("Could not create office", outcome_office_creation);
+
+            //in order to populate helper sheets
+            ClientHelper clientHelper = new ClientHelper(requestSpec, responseSpec);
+            Integer outcome_client_creation = clientHelper.createClient(requestSpec, responseSpec);
+            Assert.assertNotNull("Could not create client", outcome_client_creation);
+
+            //in order to populate helper sheets
+            GroupHelper groupHelper = new GroupHelper(requestSpec, responseSpec);
+            Integer outcome_group_creation = groupHelper.createGroup(requestSpec, responseSpec,
true);
+            Assert.assertNotNull("Could not create group", outcome_group_creation);
+
+            //in order to populate helper sheets
+            StaffHelper staffHelper = new StaffHelper();
+            Integer outcome_staff_creation = staffHelper.createStaff(requestSpec, responseSpec);
+            Assert.assertNotNull("Could not create staff", outcome_staff_creation);
+
+            SavingsProductHelper savingsProductHelper = new SavingsProductHelper();
+            String jsonSavingsProduct = savingsProductHelper.build();
+            Integer outcome_sp_creaction = savingsProductHelper.createSavingsProduct(jsonSavingsProduct,
requestSpec, responseSpec);
+            Assert.assertNotNull("Could not create Savings product", outcome_sp_creaction);
+
+            SavingsAccountHelper savingsAccountHelper = new SavingsAccountHelper(requestSpec,
responseSpec);
+            Workbook workbook = savingsAccountHelper.getSavingsWorkbook("dd MMMM yyyy");
+
+            //insert dummy data into Savings sheet
+            Sheet savingsSheet = workbook.getSheet(TemplatePopulateImportConstants.SAVINGS_ACCOUNTS_SHEET_NAME);
+            Row firstSavingsRow = savingsSheet.getRow(1);
+            Sheet officeSheet = workbook.getSheet(TemplatePopulateImportConstants.OFFICE_SHEET_NAME);
+            firstSavingsRow.createCell(SavingsConstants.OFFICE_NAME_COL).setCellValue(officeSheet.getRow(1).getCell(1).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.SAVINGS_TYPE_COL).setCellValue("Individual");
+            firstSavingsRow.createCell(SavingsConstants.CLIENT_NAME_COL).setCellValue(savingsSheet.getRow(1).getCell(SavingsConstants.LOOKUP_CLIENT_NAME_COL).getStringCellValue());
+            Sheet savingsProductSheet = workbook.getSheet(TemplatePopulateImportConstants.PRODUCT_SHEET_NAME);
+            firstSavingsRow.createCell(SavingsConstants.PRODUCT_COL).setCellValue(savingsProductSheet.getRow(1).getCell(1).getStringCellValue());
+            Sheet staffSheet = workbook.getSheet(TemplatePopulateImportConstants.STAFF_SHEET_NAME);
+            firstSavingsRow.createCell(SavingsConstants.FIELD_OFFICER_NAME_COL).setCellValue(staffSheet.getRow(1).getCell(1).getStringCellValue());
+            SimpleDateFormat simpleDateFormat = new SimpleDateFormat("dd MMMM yyyy");
+            Date date = simpleDateFormat.parse("13 May 2017");
+            firstSavingsRow.createCell(SavingsConstants.SUBMITTED_ON_DATE_COL).setCellValue(date);
+            firstSavingsRow.createCell(SavingsConstants.APPROVED_DATE_COL).setCellValue(date);
+            firstSavingsRow.createCell(SavingsConstants.ACTIVATION_DATE_COL).setCellValue(date);
+            firstSavingsRow.createCell(SavingsConstants.CURRENCY_COL).setCellValue(savingsProductSheet.getRow(1).getCell(10).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.DECIMAL_PLACES_COL).setCellValue(savingsProductSheet.getRow(1).getCell(11).getNumericCellValue());
+            firstSavingsRow.createCell(SavingsConstants.IN_MULTIPLES_OF_COL).setCellValue(savingsProductSheet.getRow(1).getCell(12).getNumericCellValue());
+            firstSavingsRow.createCell(SavingsConstants.NOMINAL_ANNUAL_INTEREST_RATE_COL).setCellValue(savingsProductSheet.getRow(1).getCell(2).getNumericCellValue());
+            firstSavingsRow.createCell(SavingsConstants.INTEREST_COMPOUNDING_PERIOD_COL).setCellValue(savingsProductSheet.getRow(1).getCell(3).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.INTEREST_POSTING_PERIOD_COL).setCellValue(savingsProductSheet.getRow(1).getCell(4).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.INTEREST_CALCULATION_COL).setCellValue(savingsProductSheet.getRow(1).getCell(5).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.INTEREST_CALCULATION_DAYS_IN_YEAR_COL).setCellValue(savingsProductSheet.getRow(1).getCell(6).getStringCellValue());
+            firstSavingsRow.createCell(SavingsConstants.MIN_OPENING_BALANCE_COL).setCellValue(1000.0);
+            firstSavingsRow.createCell(SavingsConstants.LOCKIN_PERIOD_COL).setCellValue(1);
+            firstSavingsRow.createCell(SavingsConstants.LOCKIN_PERIOD_FREQUENCY_COL).setCellValue("Weeks");
+            firstSavingsRow.createCell(SavingsConstants.APPLY_WITHDRAWAL_FEE_FOR_TRANSFERS).setCellValue("False");
+            firstSavingsRow.createCell(SavingsConstants.ALLOW_OVER_DRAFT_COL).setCellValue("False");
+            firstSavingsRow.createCell(SavingsConstants.OVER_DRAFT_LIMIT_COL).setCellValue(savingsProductSheet.getRow(1).getCell(15).getNumericCellValue());
+
+            String currentdirectory = new File("").getAbsolutePath();
+            File directory = new File(currentdirectory + File.separator + "src" + File.separator
+ "integrationTest" + File.separator +
+                    "resources" + File.separator + "bulkimport" + File.separator + "importhandler"
+ File.separator + "savings");
+            if (!directory.exists())
+                directory.mkdirs();
+            File file = new File(directory + File.separator + "Savings.xls");
+            OutputStream outputStream = new FileOutputStream(file);
+            workbook.write(outputStream);
+            outputStream.close();
+
+            String importDocumentId = savingsAccountHelper.importSavingsTemplate(file);
+            file.delete();
+            Assert.assertNotNull(importDocumentId);
+
+            //Wait for the creation of output excel
+            Thread.sleep(10000);
+
+            //check status column of output excel
+            String location = savingsAccountHelper.getOutputTemplateLocation(importDocumentId);
+
+            Utils.waitUntilFileCreation(location);
+
+            FileInputStream fileInputStream = new FileInputStream(location);
+            Workbook Outputworkbook = new HSSFWorkbook(fileInputStream);
+            Sheet OutputSavingsSheet = Outputworkbook.getSheet(TemplatePopulateImportConstants.SAVINGS_ACCOUNTS_SHEET_NAME);
+            Row row = OutputSavingsSheet.getRow(1);
+            Assert.assertEquals("Imported", row.getCell(SavingsConstants.STATUS_COL).getStringCellValue());
+            
+        } catch (AssertionError error) {
+            // Output expected AssertionErrors.
+            System.out.println("AssertionError: "+error);
 
 Review comment:
   This does not look right, to me... a test which `catch (AssertionError error)`, and then
`System.out.println("AssertionError: "+error)` it, is unusual. If you are trying to express
that you expect something int this test to fail, then that should be written differently.
Perhaps an existing `Assert` can simply be changed/improved/fixed? it should also be more
"fine grained", only around the section expecting to fail. For example, the way you currently
have it, the test will PASS if any of those `Assert.assertNotNull()` FAIL - I doubt that's
what you want here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message