fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)
Date Sun, 12 Jan 2020 12:39:16 GMT
vorburger commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702)

URL: https://github.com/apache/fineract/pull/684#issuecomment-573411261
 
 
   > Is this still relevant?
   
   Yes, very much so; this contains more but new SpotBugs related / inspired clean up which
I coded on top of your recent work! See #685 re. how this was meant to be reviewed as an addendum
to #682 .. now that is in, the diff will look clearer. The Conflicts shown are bogus (I don't
really understand why GitHub is that stupid; a simple `git rebase` on the CLI fixes them).
   
   I'm just looking into why `ShareAccountIntegrationTests` (only) fails on this PR. Maybe
I'll break it up into smaller ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message