fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #682: use SpotBugs and fix over 300 high priority Rule Violations (FINERACT-702)
Date Fri, 10 Jan 2020 21:03:49 GMT
vorburger commented on issue #682: use SpotBugs and fix over 300 high priority Rule Violations
(FINERACT-702)
URL: https://github.com/apache/fineract/pull/682#issuecomment-573204626
 
 
   @awasum doing a rebase and squash of your #670, so that we have a simple clean git history,
was much less trivial than I thought... :smiley:  because of the merge commits created by
GitHub when you accepted those change proposals I made, and then made further changes.
   
   This was supposed to be it, but it's not 1000% identical to your #670, as I had to "manually"
re-port some of the changes.. thought it was very close, but seems to be missing something,
as 3 ITs are now failing here. :sob: I'll see if I can figure out the difference, shout if
you do first. If we can't, we could always merge yours (but this would be nicer).
   
   I'll be raising a new PR for some additional proposed related clean up from myself based
off the 2nd commit on https://github.com/apache/fineract/compare/develop...vorburger:spotbugs-extra.
(We can decide later if we cherry pick those on top of #670 if you go for merging that after
all, or if we can figure this one out.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message