fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues
Date Fri, 10 Jan 2020 16:14:15 GMT
vorburger commented on issue #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority
issues
URL: https://github.com/apache/fineract/pull/670#issuecomment-573100226
 
 
   @awasum I'd like to get this in (sorry my delay-...), so I'm going to go about reviewing
it differently - I'll pull your branch, squash all of your work into a single commit (with
you as the commit's author!), quickly  resolve the (trivial) merge conflict caused by #678
myself, and then add one single new commit with changes I would have suggested you make in
the final round of review, and then raise a new PR for you to re-review and self-merge - hope
that's OK with you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message