fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #629: Swagger documentation gsoc2019
Date Fri, 10 Jan 2020 15:09:18 GMT
vorburger commented on issue #629: Swagger documentation gsoc2019
URL: https://github.com/apache/fineract/pull/629#issuecomment-573072847
 
 
   @kangbreder this PR is now looking much much better than ever before - congratulations!
   
   There are just 2 conflicts, due to the recent merge of #678 - could you manually resolve
those? Once those conflicts are resolved and when this passes the builds, then this looks
good to me, and I'm happy to merge it ASAP - let's still get this into release 1.4.0! @Sanyam96
@awasum  does this have LGTM from you guys as well, as-is?
   
   PS: One thing I would love to understand better, and I'm sure others would like to as well,
is how this will actually be used? I'm sure to you this is "obvious", but to all those of
us who have not been involved in the details this GSOC project, would it be possible to have
some "doc" for this? It doesn't matter if initially it's given here or in [FINERACT-733](https://jira.apache.org/jira/browse/FINERACT-733)
or may be somewhere on the Apache Confluence Wiki. Just to understand, once we merge this,
what does this actually "do" - you know what I mean? I gather these two new Gradle plugins
you are adding (io.swagger.core.v3.swagger-gradle-plugin and org.hidetake.swagger.generator)
do... what - just generate the src/main/resources/swagger-ui/response.json file? Can I ask
why we need 2 plugins to generate 1 file? :smiling_imp: Or do these to more
   
   I can see that file already exists now, but I'm not clear where that's coming from, and
how it was initially built.. does someone else know? @Sanyam96 perhaps? Is that this PR contributes,
in essence, really the automatic build of that file?
   
   If that new src/main/resources/swagger-ui/response.json file is (now) a generated artifact,
then why is it in Git, and generated under src/ instead of just being put in the right place
under build/ so that it ends up in the WAR? Perhaps that could be contributed as a follow-up
once we have merged this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message