From commits-return-6950-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sat Dec 14 14:44:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0EE76180629 for ; Sat, 14 Dec 2019 15:44:48 +0100 (CET) Received: (qmail 77850 invoked by uid 500); 14 Dec 2019 14:44:47 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 77742 invoked by uid 99); 14 Dec 2019 14:44:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Dec 2019 14:44:47 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues Message-ID: <157633468695.852.6484370951674394342.gitbox@gitbox.apache.org> Date: Sat, 14 Dec 2019 14:44:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues URL: https://github.com/apache/fineract/pull/670#discussion_r357919077 ########## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityDataTableChecksTemplateData.java ########## @@ -18,13 +18,15 @@ */ package org.apache.fineract.infrastructure.dataqueries.data; +import org.apache.commons.lang.builder.EqualsBuilder; Review comment: why use Commons Lang EqualsBuilder and HashCodeBuilder here when everywhere else we just use java.lang.Objects's helpers? Perhaps better to stay consistent? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services