From commits-return-6789-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Dec 2 06:03:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 15DA818064E for ; Mon, 2 Dec 2019 07:03:25 +0100 (CET) Received: (qmail 78006 invoked by uid 500); 2 Dec 2019 06:03:25 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 77997 invoked by uid 99); 2 Dec 2019 06:03:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2019 06:03:25 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #662: FINERACT-797: Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle Message-ID: <157526660532.15251.9350273943504463589.gitbox@gitbox.apache.org> Date: Mon, 02 Dec 2019 06:03:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #662: FINERACT-797: Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle URL: https://github.com/apache/fineract/pull/662#discussion_r352431208 ########## File path: fineract-provider/src/test/java/org/apache/fineract/mix/report/service/XBRLBuilderTest.java ########## @@ -79,10 +79,13 @@ public void shouldCorrectlyBuildMap() { nodes = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new ByteArrayInputStream(result.getBytes())) .getElementsByTagName("Assets"); } catch (final SAXException e) { + // TODO Auto-generated catch block e.printStackTrace(); } catch (final IOException e) { + // TODO Auto-generated catch block e.printStackTrace(); } catch (final ParserConfigurationException e) { + // TODO Auto-generated catch block Review comment: ```suggestion ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services