fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues
Date Mon, 16 Dec 2019 10:23:14 GMT
awasum commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix
over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r358153774
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/domain/LoanProductProvisioningEntry.java
 ##########
 @@ -125,4 +126,9 @@ public boolean equals(Object obj) {
                 && entry.office.getId().equals(this.office.getId())
                 && entry.getCurrencyCode().equals(this.getCurrencyCode());
     }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(entry, criteriaId, office, currencyCode, loanProduct, provisioningCategory,
overdueInDays, reservedAmount, liabilityAccount, expenseAccount);
 
 Review comment:
   Thanks. Fixing this and also adjusting equals() to use Objects.equals() too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message