fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues
Date Sat, 14 Dec 2019 14:44:46 GMT
vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and
fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357919077
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityDataTableChecksTemplateData.java
 ##########
 @@ -18,13 +18,15 @@
  */
 package org.apache.fineract.infrastructure.dataqueries.data;
 
+import org.apache.commons.lang.builder.EqualsBuilder;
 
 Review comment:
   why use Commons Lang EqualsBuilder and HashCodeBuilder here when everywhere else we just
use java.lang.Objects's helpers? Perhaps better to stay consistent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message