fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] jamesidw commented on issue #660: FINERACT-803: validate username uniqueness
Date Wed, 04 Dec 2019 12:59:27 GMT
jamesidw commented on issue #660: FINERACT-803: validate username uniqueness
URL: https://github.com/apache/fineract/pull/660#issuecomment-561632278
 
 
   Thanks @santoshconflux from this file [notificationWidget.js](https://github.com/openMF/community-app/blob/develop/app/scripts/modules/notificationWidget.js)
it seems the correct approach is to use the `userMessageGlobalisationCode` instead. There
is [already a code](https://github.com/openMF/community-app/blob/c48f89dc3397aaa16cad1cabfd6324e802e12fcd/app/global-translations/locale-en.json#L2372)
that can work for this on the frontend so the fix would entail changing the `userMessageGlobalisationCode`
being returned to match that.
   
   @mohitsinha not sure what the correct approach is:
   
   * Revert the changes and create a new PR?
   * Create a new PR to fix what's already been merged?
   
   Please advise

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message