fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #661: FINERACT-777 api / implementation scoped dependencies
Date Mon, 02 Dec 2019 00:59:35 GMT
vorburger commented on a change in pull request #661: FINERACT-777 api / implementation scoped
dependencies
URL: https://github.com/apache/fineract/pull/661#discussion_r352388844
 
 

 ##########
 File path: fineract-provider/build.gradle
 ##########
 @@ -57,7 +57,7 @@ apply plugin: 'eclipse'
 apply plugin: 'idea'
 apply plugin: 'com.bmuschko.tomcat'
 apply plugin: 'project-report'
-apply plugin: 'java'
+apply plugin: 'java-library'
 
 Review comment:
   @percyashu could you reply with a note for future code archeologists here why this change
was needed?  As it seems to still work anyway, I'm inclined to merge this even without fully
understanding what exactly this changes, if anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message