From commits-return-1157-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Jan 22 16:01:01 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9BA5318079E for ; Mon, 22 Jan 2018 16:01:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 871FB160C4C; Mon, 22 Jan 2018 15:01:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AC7CE160C3A for ; Mon, 22 Jan 2018 16:00:59 +0100 (CET) Received: (qmail 11721 invoked by uid 500); 22 Jan 2018 15:00:58 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 11701 invoked by uid 99); 22 Jan 2018 15:00:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jan 2018 15:00:58 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id D706981FC8; Mon, 22 Jan 2018 15:00:55 +0000 (UTC) Date: Mon, 22 Jan 2018 15:01:04 +0000 To: "commits@fineract.apache.org" Subject: [fineract-cn-lang] 09/49: Set upper limit on length so that application names can be saved in an SQL table. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: myrle@apache.org In-Reply-To: <151663325509.14804.2883341681694436220@gitbox.apache.org> References: <151663325509.14804.2883341681694436220@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: fineract-cn-lang X-Git-Refname: refs/heads/develop X-Git-Reftype: branch X-Git-Rev: cefa08c7e871c78d8c43f77b2ae147030a9a2531 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20180122150055.D706981FC8@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. myrle pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-lang.git commit cefa08c7e871c78d8c43f77b2ae147030a9a2531 Author: myrle-krantz AuthorDate: Tue Apr 4 22:13:52 2017 +0200 Set upper limit on length so that application names can be saved in an SQL table. --- src/main/java/io/mifos/core/lang/ApplicationName.java | 4 ++++ .../core/lang/validation/ValidApplicationNameTest.java | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/src/main/java/io/mifos/core/lang/ApplicationName.java b/src/main/java/io/mifos/core/lang/ApplicationName.java index d984eb6..c3da900 100644 --- a/src/main/java/io/mifos/core/lang/ApplicationName.java +++ b/src/main/java/io/mifos/core/lang/ApplicationName.java @@ -41,6 +41,10 @@ public class ApplicationName { } static ApplicationName parse(final String springApplicationNameString) { + if (springApplicationNameString.length() > 64) { + throw new IllegalArgumentException("Spring application name strings for mifos io applications should be 64 characters or less."); + } + final Pattern applicationNamePattern = Pattern.compile( "^(/??(?\\p{Lower}[\\p{Lower}_]+)(?:-v(?\\d[\\d\\._]*))?)$"); diff --git a/src/test/java/io/mifos/core/lang/validation/ValidApplicationNameTest.java b/src/test/java/io/mifos/core/lang/validation/ValidApplicationNameTest.java index 31613d2..50481d7 100644 --- a/src/test/java/io/mifos/core/lang/validation/ValidApplicationNameTest.java +++ b/src/test/java/io/mifos/core/lang/validation/ValidApplicationNameTest.java @@ -44,6 +44,19 @@ public class ValidApplicationNameTest { } @Test + public void tooLongAppplicationName() + { + final StringBuilder stringBuilder = new StringBuilder(); + for (int i = 0; i < 65 -3; i++) { + stringBuilder.append("b"); + } + stringBuilder.append("-v1"); + + final AnnotatedClass annotatedInstance = new AnnotatedClass(stringBuilder.toString()); + Assert.assertFalse(isValid(annotatedInstance)); + } + + @Test public void nullAppplicationName() { final AnnotatedClass annotatedInstance = new AnnotatedClass(null); -- To stop receiving notification emails like this one, please contact myrle@apache.org.