fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] fineract pull request #410: sms notification
Date Tue, 24 Oct 2017 12:49:59 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/410#discussion_r146548096
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java
---
    @@ -81,10 +80,8 @@ public SmsCampaignDropdownReadPlatformServiceImpl(final SmsConfigUtils
smsConfig
                         new ParameterizedTypeReference<Collection<SmsProviderData>>()
{});
                 smsProviderOptions = responseOne.getBody();
                 if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
    -                throw new ConnectionFailureException(hostName);
                 }
             } catch (Exception e) {
    -        	 throw new ConnectionFailureException(hostName);
    --- End diff --
    
    We removed this exception , when sms will be send at that time it will throw validation
message for the same.


---

Mime
View raw message