Mailing-List: contact users-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@felix.apache.org
From: David Jencks <david.a.jencks@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: Using OSGi DS and old Apache Felix SCR together
Date: Thu, 16 Mar 2017 09:32:50 -0700
References: <22AB12EE-DDB7-4EB5-A9DD-6B400AF2CB6E@teeuwen.be>
 <89a34cfbfd994f0cbdac647b200f7842@mailx01.intern.pro-vision.de>
To: users@felix.apache.org
In-Reply-To: <89a34cfbfd994f0cbdac647b200f7842@mailx01.intern.pro-vision.de>
Message-Id: <4C5848C1-EE84-4D3D-B5EB-2E1D3AA37599@gmail.com>
archived-at: Thu, 16 Mar 2017 16:39:31 -0000

I think the bnd support is for the proprietary bnd annotations, not the =
proprietary felix annotations. AFAIR bnd never supported the proprietary =
felix scr annotations.

I also think that bnd (and thus the maven-bundle-plugin) runs and  =
generates the xml after the unit tests run, so that you will never be =
able to  get the xml=E2=80=99s in time for unit tests.  I don=E2=80=99t =
know if integration tests (failsafe plugin) run before or after the =
bundle is assembled, but I think after, so  perhaps that would be worth =
looking into.

david jencks


> On Mar 16, 2017, at 2:09 AM, Stefan Seifert <sseifert@pro-vision.de> =
wrote:
>=20
> you should not use the maven-scr-plugin at all in this case - there is =
a bnd plugin for the old felix SCR annotations that does the same job.
> so use only maven-bundle-plugin and add an instruction
> =
<_plugin>org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=3D$=
{project.build.outputDirectory}</plugin>
>=20
> for a full example see [1]
>=20
> on the long run you should migrate to the OSGi annotations and remove =
the felix scr annotations.
>=20
> stefan
>=20
> [1] =
https://github.com/wcm-io/wcm-io-tooling/blob/develop/maven/aem-global-par=
ent/pom.xml
>=20
>=20
>> -----Original Message-----
>> From: Roy Teeuwen [mailto:roy@teeuwen.be]
>> Sent: Thursday, March 16, 2017 9:03 AM
>> To: users@felix.apache.org
>> Subject: Using OSGi DS and old Apache Felix SCR together
>>=20
>> Hey all,
>>=20
>> I am running in a problem when trying to use OSGi DS annotations and =
Apache
>> Felix annotations together. I have unit tests that depend on the =
service
>> xml's being present (I am using the Apache Sling osgi-mock to run =
unit
>> tests), but the problem that I am facing is that when the =
maven-bundle-
>> plugin:manifest phase has been executed, the maven-scr-plugin deletes =
the
>> maven-bundle-plugin xml's again created by the maven-bundle manifest =
phase,
>> is there any way to avoid this and make it that they are merged =
togheter?
>> All xmls are present in the JAR file when everything is compiled so =
in the
>> end it works out, but I need them for the unit tests too.
>>=20
>> The configuration I am currently using at the moment:
>>=20
>> <plugin>
>>   <groupId>org.apache.felix</groupId>
>>   <artifactId>maven-bundle-plugin</artifactId>
>>   <version>3.2.0</version>
>>   <configuration>
>>       <instructions>
>>           ...
>>           <_dsannotations>*</_dsannotations>
>>           <_metatypeannotations>*</_metatypeannotations>
>>       </instructions>
>>       <exportScr>true</exportScr>
>>   </configuration>
>>   <executions>
>>       <!--
>>           Configure extra execution of 'manifest' in process-classes
>> phase
>>           to make sure SCR metadata is generated before unit test =
runs
>>       -->
>>       <execution>
>>           <id>scr-metadata</id>
>>           <goals>
>>               <goal>manifest</goal>
>>           </goals>
>>           <configuration>
>>               <supportIncrementalBuild>true</supportIncrementalBuild>
>>           </configuration>
>>       </execution>
>>   </executions>
>> </plugin>
>> <plugin>
>>   <groupId>org.apache.felix</groupId>
>>   <artifactId>maven-scr-plugin</artifactId>
>>   <version>1.24.0</version>
>>   <executions>
>>       <execution>
>>           <id>generate-scr-reportDescriptor</id>
>>           <goals>
>>               <goal>scr</goal>
>>           </goals>
>>       </execution>
>>   </executions>
>> </plugin>
>>=20
>> Greetings,
>> Roy
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
>> For additional commands, e-mail: users-help@felix.apache.org
>>=20
>=20
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
> For additional commands, e-mail: users-help@felix.apache.org
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
For additional commands, e-mail: users-help@felix.apache.org