Mailing-List: contact users-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@felix.apache.org
Received-SPF: pass (athena.apache.org: domain of gnodet@gmail.com designates
 74.125.82.53 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=H5fWV5A7KE3UyLhatXj288IKyL/IljAh9bShnXmSnjaKzjnAMYJA7VzSfPedqDdfBE
         jSBjv8Hv1cKnfggpAYE9sZCcNfIllf8CgsRqRvZ+R1NfzQIUc1dlVHSd/svZwUIm+Gzb
         kGJPeggmP4771vYpukQ+zEPryzNSoitDQ0zMk=
MIME-Version: 1.0
In-Reply-To: <19319862-16D1-48A0-A83B-432FEABC39AE@apache.org>
References: <AANLkTimsQDTKP89RtV7Sf5D6T94qAKqCRgsYsKXfBe5e@mail.gmail.com>
	<AANLkTinCK4VSxoJDn8fXT3LCn_nYgyGfBwV0A8zQ=6JJ@mail.gmail.com>
	<19319862-16D1-48A0-A83B-432FEABC39AE@apache.org>
Date: Wed, 2 Mar 2011 00:33:37 +0100
Message-ID: <AANLkTimDobFj00AZ0haZq=aTgY6aXTfvU9U6KUH3+9Fz@mail.gmail.com>
Subject: Re: ArtifactInstaller.canHandle being passed a jar
From: Guillaume Nodet <gnodet@gmail.com>
To: users@felix.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I think changing the extension to not include ".jar" in the zipped jar
for an expanded directory should be easy to do.
And I agree the ArtifactInstaller + exploded directory seems somewhat broke=
n.
Feel free to raise a JIRA (and eventually attach a patch).

On Tue, Mar 1, 2011 at 21:31, Alasdair Nottingham <not@apache.org> wrote:
> That doesn't work for me because I have to use the extension. Also I'm no=
t dealing with bundles here.
>
> If I'm honest this seems broken, my canHandle could pass, but install fai=
l because I can't deal with a directory, when offering to handle I don't kn=
ow if it is a file or a directory.
>
> Alasdair Nottingham
>
> On 1 Mar 2011, at 19:56, Guillaume Nodet <gnodet@gmail.com> wrote:
>
>> The code doesn't work if you do a check based on the extension because
>> if you've seen the extension is lost when using exploded bundles.
>> What I've seen usually is to have the canHandle() method opening the
>> jar and look for a specific file in the zip or manifest information do
>> better determine if the artifact is supported or not. =A0For example the
>> pax-web deployer looks for a WEB-INF/web.xml file.
>>
>> On Tue, Mar 1, 2011 at 20:33, Alasdair Nottingham <not@apache.org> wrote=
:
>>> Hi,
>>>
>>> In aries we have an ArtifactInstaller for FileInstall that is will
>>> install an OSGi Application. The code, in theory, can cope with it
>>> being either an archive with a .eba extension, or an expanded
>>> directory (also with a .eba extension). This does not work though. The
>>> reason is that when canHandle is called I am provided a jared up
>>> version of the directory, which ends with .jar. As a result canHandle
>>> returns false.
>>>
>>> If it returned true then the install method is called, but is passed
>>> the directory in watched directory. I was wondering why different
>>> things are being passed in these two cases. What is the right way to
>>> cope in this situation and correctly identify myself as being
>>> responsible.
>>>
>>> Thanks
>>> Alasdair
>>>
>>> --
>>> Alasdair Nottingham
>>> not@apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
>>> For additional commands, e-mail: users-help@felix.apache.org
>>>
>>>
>>
>>
>>
>> --
>> Cheers,
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
>> For additional commands, e-mail: users-help@felix.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
> For additional commands, e-mail: users-help@felix.apache.org
>
>


--=20
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
For additional commands, e-mail: users-help@felix.apache.org