felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FELIX-5686) NPE in ConfigInstaller on ConfigDelete
Date Thu, 19 Oct 2017 07:32:01 GMT

     [ https://issues.apache.org/jira/browse/FELIX-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Guillaume Nodet resolved FELIX-5686.
       Resolution: Fixed
         Assignee: Guillaume Nodet
    Fix Version/s: fileinstall-3.7.0

Committing to https://svn.apache.org/repos/asf/felix/trunk ...
	M	fileinstall/src/main/java/org/apache/felix/fileinstall/internal/ConfigInstaller.java
Committed r1812602

> NPE in ConfigInstaller on ConfigDelete
> --------------------------------------
>                 Key: FELIX-5686
>                 URL: https://issues.apache.org/jira/browse/FELIX-5686
>             Project: Felix
>          Issue Type: Bug
>    Affects Versions: fileinstall-3.6.0
>            Reporter: Brandan Jeter
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-3.7.0
> The ConfigInstaller is handling a Config Delete Event now, but it always throws a NullPointException
which crowds up the logs.
> On delete, the ConfigInstaller tries to get the corresponding Configuration object: https://github.com/apache/felix/blob/trunk/fileinstall/src/main/java/org/apache/felix/fileinstall/internal/ConfigInstaller.java#L176
> It's never going to get the Configuration object because it was just deleted. So the
getConfiguration call creates a new one with null as the properties. Then on line 180 there
is a NullPointerException. 
> Unfortunately, the fix for this will require changing the ConfigurationListener API so
that the ConfigurationEvent either has the whole Dictionary of configuration properties or
at least the felix.file.install property, if it exists.

This message was sent by Atlassian JIRA

View raw message