Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 69A26200CFC for ; Thu, 14 Sep 2017 03:21:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 680BD1609CC; Thu, 14 Sep 2017 01:21:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ADEF01609CA for ; Thu, 14 Sep 2017 03:21:03 +0200 (CEST) Received: (qmail 75072 invoked by uid 500); 14 Sep 2017 01:21:02 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 75061 invoked by uid 99); 14 Sep 2017 01:21:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Sep 2017 01:21:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4BC3A18CEAD for ; Thu, 14 Sep 2017 01:21:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4z4mQaS6JGnm for ; Thu, 14 Sep 2017 01:21:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 247665FC21 for ; Thu, 14 Sep 2017 01:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60035E00C9 for ; Thu, 14 Sep 2017 01:21:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D26725383 for ; Thu, 14 Sep 2017 01:21:00 +0000 (UTC) Date: Thu, 14 Sep 2017 01:21:00 +0000 (UTC) From: "Joshua Mack (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FELIX-5690) ConfigurationHandler should support ignoring whitespace between property key/equal sign & equal sign/property value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 14 Sep 2017 01:21:04 -0000 [ https://issues.apache.org/jira/browse/FELIX-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua Mack updated FELIX-5690: ------------------------------- Attachment: FELIX-5690.patch > ConfigurationHandler should support ignoring whitespace between property key/equal sign & equal sign/property value > ------------------------------------------------------------------------------------------------------------------- > > Key: FELIX-5690 > URL: https://issues.apache.org/jira/browse/FELIX-5690 > Project: Felix > Issue Type: Improvement > Components: Configuration Admin > Reporter: Joshua Mack > Priority: Minor > Labels: easyfix > Attachments: FELIX-5690.patch > > > ConfigurationHandler.read(InputStream ins) should properly parse input streams that have whitespace between key/equals sign and the equals sign/value. > A situation like > `service.pid ="com.adobe.granite.foo.Bar"` > causes a single extra space to be included with the key's String > (i.e. dictionary.get("service.pid" + " ") == "com.adobe.granite.foo.Bar") > And a situation like > `service.pid= "com.adobe.granite.foo.Bar"` > causes the value read to be null and thus the entry not added to the dictionary > (i.e. dictionary.size() == 0 and dictionary.get("service.pid") == null) > The class inherently supports spaces before the property name (i.e. ` service.pid=...`) with the ignorableWhiteSpace call in nextToken. The class should be adjusted to similarly ignore whitespace between the key and equals sign as well as between the equals sign and the value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)