Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39096200CDA for ; Fri, 4 Aug 2017 12:48:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 35CFD16D6D1; Fri, 4 Aug 2017 10:48:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79EB216D6CC for ; Fri, 4 Aug 2017 12:48:06 +0200 (CEST) Received: (qmail 19878 invoked by uid 500); 4 Aug 2017 10:48:05 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 19865 invoked by uid 99); 4 Aug 2017 10:48:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 10:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 376CFC0043 for ; Fri, 4 Aug 2017 10:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tFSLqoGdAgYN for ; Fri, 4 Aug 2017 10:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B0FA35F6BE for ; Fri, 4 Aug 2017 10:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EC134E0D45 for ; Fri, 4 Aug 2017 10:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3302824652 for ; Fri, 4 Aug 2017 10:48:00 +0000 (UTC) Date: Fri, 4 Aug 2017 10:48:00 +0000 (UTC) From: "David Bosschaert (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-5670) Facade caching for optimisation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 04 Aug 2017 10:48:07 -0000 [ https://issues.apache.org/jira/browse/FELIX-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114233#comment-16114233 ] David Bosschaert commented on FELIX-5670: ----------------------------------------- Hi [~dleangen] thanks for the observation, but I have to admit that the bug description is a little bit vague. What areas do you think would benefit from caching? Also before we actually implement such a cache, which might make the implementation larger/more complex, we should ensure that it's really needed. The Java HotSpot sometimes optimizes things out so that manually implemented optimizations become moot... > Facade caching for optimisation > ------------------------------- > > Key: FELIX-5670 > URL: https://issues.apache.org/jira/browse/FELIX-5670 > Project: Felix > Issue Type: Improvement > Components: Converter > Reporter: David Leangen > Priority: Minor > > When stepping through the code, I noticed that the same blocks were being called repeatedly. > A little bit of investigation would be good, but I believe that having a cache for some of the values could provide an opportunity to optimize. > Probably a bit premature for this version, though, so maybe something to get back to a little later. -- This message was sent by Atlassian JIRA (v6.4.14#64029)