felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomas Polesovsky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5468) Refactor persistence handling
Date Thu, 25 May 2017 15:17:04 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024852#comment-16024852

Tomas Polesovsky commented on FELIX-5468:

Hi [~cziegeler],

during our analysis of threads heavily locked in https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/CachingPersistenceManagerProxy.java
we found there are lost changes in the repository.

The commit named "Move R7 work to osgi-r7 directory" overwrote changes of "FELIX-5468 : Refactor
persistence handling (WiP)" as can be seen on https://github.com/apache/felix/commits/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/CachingPersistenceManagerProxy.java

This ticket is closed so we guess it was unwanted change.

Only FYI :)


> Refactor persistence handling
> -----------------------------
>                 Key: FELIX-5468
>                 URL: https://issues.apache.org/jira/browse/FELIX-5468
>             Project: Felix
>          Issue Type: Improvement
>          Components: Configuration Admin
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: configadmin-1.9.0
> The handling of persistence managers has grown over time and has now a rather entangled
implementation checking in various places if the underlying persistence manager is caching
or not. 
> In addition read/write locking is done on a persistence manager level but not across
all available persistence managers.
> I think if we move the whole persistence manager handling code into a separate component,
the code gets cleaner and easier to test

This message was sent by Atlassian JIRA

View raw message