Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E63E2200C5F for ; Sun, 23 Apr 2017 17:36:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E4D13160BA6; Sun, 23 Apr 2017 15:36:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3899E160B8E for ; Sun, 23 Apr 2017 17:36:55 +0200 (CEST) Received: (qmail 61779 invoked by uid 500); 23 Apr 2017 15:36:54 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 61767 invoked by uid 99); 23 Apr 2017 15:36:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2017 15:36:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A5977C25A9 for ; Sun, 23 Apr 2017 15:36:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OWlPH9eUhy55 for ; Sun, 23 Apr 2017 15:36:49 +0000 (UTC) Received: from mail-it0-f46.google.com (mail-it0-f46.google.com [209.85.214.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4C7425FC83 for ; Sun, 23 Apr 2017 15:36:49 +0000 (UTC) Received: by mail-it0-f46.google.com with SMTP id g66so32122318ite.1 for ; Sun, 23 Apr 2017 08:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=D0+suyFxg7Ng4WdOQK5TOev6yl0gg4i7oo3LFdyerXo=; b=VCGgg833yjWwI9VkhMg6nUDqEITpmIwtO88D88rmluPjTI8ZLkn+9GsMSxl/cNM7gd iSz2OBDpMVERpq4gjXmPhOWnSus998oAXsbwc6K4QvgeubiWKfhRm2Hf/A3BM7vJleD8 BiztRfiPYUaRwiLsKpnH2ayKH3dmNqrzWHcn6JlL0IOH5SmVmCxUdBPXE0zBWhHq0mm+ 89XX3lfFjM3i4QSYiJNy5nnDYgtSDlHT1SKdSuq5cKI0QxoggLUmXAUlsLqj36moFmqO HLcVQ6qaHHz47HVWnaMJ/K9r9T1O9XNgRbIHnU1k/t9/Qvji8+Kq9w2MqUEfs8KOtJFm PFhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=D0+suyFxg7Ng4WdOQK5TOev6yl0gg4i7oo3LFdyerXo=; b=CaTjJ8zRhG6FdaiN43HeFJ6y+Fc/+p8/ibJ6AosBbFPuM9IvyyaZT/5AXiW4J+cz2S yF3+NUvAJ0wSXY193kD0sy0qQy9kSQ01EkgxFcvIOkcz3cevtvYOIpiNjFILFqWpTKbO fr4iFtaHpIK4v+F35C6EoGrbKD764es9r1RSMnOEv4Ehe6nJZUBGGUFJ7pOe6ZqwvDhF 3Tk0d6KJYLvbcPeLu4+1KAp1ctqpaX1NsEFLVMBDwnuKf2l2nzi1wVvk6FHx/gxPtQzA nb1CFW85OPVeJ9uL0THT/fKjDOVDikYE9K0BCbXygK14VMPd+YnOZqUFsbvF25VnDoBi vTlw== X-Gm-Message-State: AN3rC/6rgCKZRs+cZU3zZixzzagWz9nGv27fHVDP5+VaruVWdLy1mPyj Ape5L/BCWIJBhxjfhCU= X-Received: by 10.99.2.84 with SMTP id 81mr11003722pgc.17.1492961802648; Sun, 23 Apr 2017 08:36:42 -0700 (PDT) Received: from macbook-pro-2.domain (184-100-236-131.ptld.qwest.net. [184.100.236.131]) by smtp.gmail.com with ESMTPSA id p3sm344344pgd.36.2017.04.23.08.36.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Apr 2017 08:36:41 -0700 (PDT) From: David Jencks Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Including sources in bundles Date: Sun, 23 Apr 2017 08:36:41 -0700 References: <607751BC-E6AA-42F3-8987-EB871C7E8796@gmail.com> To: dev@felix.apache.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3273) archived-at: Sun, 23 Apr 2017 15:36:56 -0000 I mean OSGI-OPT. The source jars for released versions are at maven central, but I was = debugging trunk, and the source jars aren=E2=80=99t built automatically = (and, actually I thought of adding source to the bundle and didn=E2=80=99t= think of building the source jar). Wrong list =E2=80=94 but would = dragging/dropping a source jar into the bndtools =E2=80=9Clocal=E2=80=9D = repo add it to the existing bundle? =20 I still think that having one artifact rather than two is more = convenient, even if bndtools finds a source jar next to any bundle you = drag and drop into a repository. thanks david jencks > On Apr 23, 2017, at 7:21 AM, Thomas Watson wrote: >=20 > I think including source is fine. >=20 > Did you mean OSGI-OPT instead of OSGI-INF. The spec recommends = OSGI-OPT be > used to include source. >=20 > I am concerned that bndtools makes it hard for one such as you to = debug our > code. If it is hard for you then it is impossible for the masses. = This > seems like a pretty big usability issue in bndtools. Are not the = source > jars published to maven central for the tools to find? >=20 > Tom. >=20 > On Sun, Apr 23, 2017 at 2:13 AM, David Jencks = > wrote: >=20 >> Working on FELIX-5618 I couldn=E2=80=99t figure out a way to debug DS = in bndtools >> without modifying the DS bundle to include sources. This is = certainly the >> easiest way to get the sources visible in a bndtools environment. = After >> this experience I=E2=80=99d like to include the sources for DS in = OSGI-INF as >> recommended by Peter et al. I=E2=80=99d like to include the sources = in the util >> jar as well, I think then the extender base classes will show up in = the DS >> bundle. >>=20 >> Any objections? >>=20 >> thanks >> david jencks >>=20 >>=20