Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Date: Thu, 2 Mar 2017 09:14:45 +0000 (UTC)
From: "Guillaume Nodet (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Message-ID: <JIRA.13047605.1488443613000.40563.1488446085704@Atlassian.JIRA>
In-Reply-To: <JIRA.13047605.1488443613000@Atlassian.JIRA>
References: <JIRA.13047605.1488443613000@Atlassian.JIRA> <JIRA.13047605.1488443613073@jira-lw-us.apache.org>
Subject: [jira] [Assigned] (FELIX-5576) SCR components and factoryPids
 random issues
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 02 Mar 2017 09:14:51 -0000


     [ https://issues.apache.org/jira/browse/FELIX-5576?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet reassigned FELIX-5576:
--------------------------------------

    Assignee: Guillaume Nodet

> SCR components and factoryPids random issues
> --------------------------------------------
>
>                 Key: FELIX-5576
>                 URL: https://issues.apache.org/jira/browse/FELIX-5576
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.2
>            Reporter: Paolo Antinori
>            Assignee: Guillaume Nodet
>
> This affects {{mvn:org.apache.felix/org.apache.felix.scr/1.8.2}}.
> There is an issue with SCR, {{ConfigAdmin}} and {{factoryPids}} that lead=
s to possible situation when {{ConfigAdmin}} update events are discarded.
> The issue is present in case of an interweaving of {{CM_LOCATION_CHANGED}=
} event.
> If that event is processed, it changes updates the reference of {{TargetP=
ID}} with the wrong one (uses {{instance}} one instead than a {{service}} o=
ne) basically turning the stored reference unreachable, thus discarding sub=
sequent update requests.
> The following code fixes the issue.
> {code}
> =E2=9C=94 /data/repositories/work/felix [org.apache.felix.scr-1.8.2|=E2=
=97=8F1=E2=9C=9A 1=E2=80=A6288]=20
> 09:30 $ git diff --cached
> diff --git a/src/main/java/org/apache/felix/scr/impl/config/Configuration=
Support.java b/src/main/java/org/apache/felix/scr/impl/config/Configuration=
Support.java
> index e2f63e9..3a15073 100644
> --- a/src/main/java/org/apache/felix/scr/impl/config/ConfigurationSupport=
.java
> +++ b/src/main/java/org/apache/felix/scr/impl/config/ConfigurationSupport=
.java
> @@ -357,8 +357,8 @@ public class ConfigurationSupport implements Configur=
ationListener
>                                  //this is a better match, delete old bef=
ore setting new
>                                  componentHolder.configurationDeleted( pi=
d.getServicePid() );
>                              }
> -                            componentHolder.configurationUpdated( pid.ge=
tServicePid(), configInfo.getProps(),
> -                                    configInfo.getChangeCount(), pid );
> +                            componentHolder.configurationUpdated( target=
edPid.getServicePid(), configInfo.getProps(),
> +                                    configInfo.getChangeCount(), targete=
dPid );
>                          }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)