felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FELIX-5543) Make component property types implement java.lang.annotation.Annotation properly
Date Tue, 14 Feb 2017 12:44:41 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865523#comment-15865523
] 

Konrad Windszus edited comment on FELIX-5543 at 2/14/17 12:44 PM:
------------------------------------------------------------------

Right now the component property type object returns {{null}} for all methods, which are not
given in the {{HashMap}} in https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/inject/Annotations.java#L246.

Instead of the simple {{Handler}} class one must implement something similar to {{sun.reflect.annotation.AnnotationInvocationHandler}}.


was (Author: kwin):
Right now the component property type object returns {{null}} for all methods, which are not
given in the {{HashMap}} in https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/inject/Annotations.java#L246.
This is not good, since each object in Java implicitly derives from https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html
which mandates a certain implementation of those methods.
Instead of the simple {{Handler}} class one must implement something similar to {{sun.reflect.annotation.AnnotationInvocationHandler}}.

> Make component property types implement java.lang.annotation.Annotation properly
> --------------------------------------------------------------------------------
>
>                 Key: FELIX-5543
>                 URL: https://issues.apache.org/jira/browse/FELIX-5543
>             Project: Felix
>          Issue Type: Improvement
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-2.1.0
>            Reporter: Konrad Windszus
>
> Currently component property types only implement one getter method for each element.
The methods {{toString()}}, {{equals()}}, {{hashCode()}} and {{annotationType}} are not implemented
properly (i.e. all return just {{null}}). The component property type object actually implements
{{java.lang.annotation.Annotation}} and therefore needs to implement its interface properly.
The current implementation is clearly violating the contract of the {{java.lang.annotation.Annotation}}.
> For that the {{Annotations#toObject(...)}} needs to be adjusted in https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/inject/Annotations.java#L41.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message