felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre De Rop (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5508) Multiple JSON Serializers
Date Mon, 06 Feb 2017 15:30:42 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854207#comment-15854207

Pierre De Rop commented on FELIX-5508:

Hi David (Bosschaert); 

for your information: for the DependencyManager, I have removed the json library and replaced
it by your json parser: it is exactly what I was looking for and it is working like a charm.

I need to make a release of dm soon, so for the moment I have "stolen" your parser, but I
will make a new release once it will be decided what parser will be put in common in the "util"
module. (but I would vote +1 for the parser from the Converter).

For the moment, I have done this: 

in [1] I'm using a JsonWriter standalone class which is an slightly adapted version from your
org.apache.felix.serializer.impl.json.JsonSerializingImpl.java class, I just removed dependencies
to outside world and replaced the converter interface by a simple java8 lambda (Function)
which also could allow to provide a converter (but I don't need this for the moment).

in [2] I'm using a JsonReader standalone class, based on your org.apache.felix.serializer.impl.json.JsonParser
class. I just moved the readStream method from the Util into the JsonReader class.

[1] http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/JsonWriter.java
[2] http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/JsonReader.java

> Multiple JSON Serializers
> -------------------------
>                 Key: FELIX-5508
>                 URL: https://issues.apache.org/jira/browse/FELIX-5508
>             Project: Felix
>          Issue Type: Improvement
>          Components: Converter
>            Reporter: David Leangen
> There appears to be multiple json serializers in the code base (serializer, schematizer,
and even more recently webconsole).
> Would it be worthwhile to consider consolidating them somehow, to avoid duplicate work?

This message was sent by Atlassian JIRA

View raw message