Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EF217200BEA for ; Tue, 27 Dec 2016 15:25:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EDBB8160B31; Tue, 27 Dec 2016 14:25:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 447ED160B23 for ; Tue, 27 Dec 2016 15:25:59 +0100 (CET) Received: (qmail 52540 invoked by uid 500); 27 Dec 2016 14:25:58 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 52523 invoked by uid 99); 27 Dec 2016 14:25:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2016 14:25:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5257A2C03DC for ; Tue, 27 Dec 2016 14:25:58 +0000 (UTC) Date: Tue, 27 Dec 2016 14:25:58 +0000 (UTC) From: "Pierre De Rop (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-5467) MultiPropertyFilterIndex is unusable when a service reference contains a lot of values for one key MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Dec 2016 14:26:00 -0000 [ https://issues.apache.org/jira/browse/FELIX-5467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780495#comment-15780495 ] Pierre De Rop commented on FELIX-5467: -------------------------------------- Hi Jeroen, we will look into your issue soon, thank you. > MultiPropertyFilterIndex is unusable when a service reference contains a lot of values for one key > -------------------------------------------------------------------------------------------------- > > Key: FELIX-5467 > URL: https://issues.apache.org/jira/browse/FELIX-5467 > Project: Felix > Issue Type: Improvement > Components: Dependency Manager > Affects Versions: org.apache.felix.dependencymanager-r8 > Reporter: Jeroen Daanen > Attachments: MultiPropertyFilterIndex.java, Property.java > > > Upon addition of a service, the MultiPropertyFilterIndex creates a set of keys using the keys and values of the service reference properties. If the value is an array of values it creates keys for each possible permutation of those values so that the service reference can be retrieved if in the service dependency filter multiple values are specified (e.g. {{(&(objectClass=SomeClass)(&(a=x)(a=n)(a=y)(b=y)(c=z)))}}). If there are a lot of values for a key this results in a huge memory consumption, making it impossible to use. > Now, in my application I always specify just one value in the service filter (e.g. there is a service which has multiple values for property "a" but I only specify one: {{(&(objectClass=SomeClass)(&(a=x)(b=y)(c=z)))}}) so I don't need those permutations, but because my property has a lot of values (>10) I cannot use the MultiPropertyFilterIndex causing a significant performance loss. > I would like to suggest to add the possibility to leave out creating the permutation of values for a service property if you specify so in your filter properties. For instance by preceding the property configuration with '#', e.g. {{-Dorg.apache.felix.dependencymanager.filterindex=\*aspect\*;\*adapter\*;objectClass;objectClass,#a,b,c}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)