Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
MIME-Version: 1.0
In-Reply-To: <CAAViHOkx7jb=cap4JsX2Ehcyd5UjwMiQC2i8wE3jK14=T50egw@mail.gmail.com>
References: <CAAViHOkx7jb=cap4JsX2Ehcyd5UjwMiQC2i8wE3jK14=T50egw@mail.gmail.com>
From: Karl Pauls <karlpauls@gmail.com>
Date: Mon, 3 Oct 2016 23:14:03 +0200
Message-ID: <CAJnwQNian2sAjN1450Z8bFwA2es5+5SX_at6DRdftSO+O=DEqA@mail.gmail.com>
Subject: Re: Re-Using an ExecutorService for Felix Resolver calls
To: "dev@felix.apache.org" <dev@felix.apache.org>
Content-Type: multipart/alternative; boundary=047d7b5d24b69814b9053dfc6d60
archived-at: Mon, 03 Oct 2016 21:14:29 -0000

--047d7b5d24b69814b9053dfc6d60
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I guess I'm not sure if this message is intended for dev@felix or dev@karaf=
?

regards,

Karl

On Mon, Oct 3, 2016 at 9:21 PM, Fabian Lange <fabian.lange@codecentric.de>
wrote:

> Hi,
> what do you guys think about:
> https://github.com/apache/karaf/pull/246
>
> As noticed by me, and already reported here:
> https://issues.apache.org/jira/browse/FELIX-5247
>
> The current default behaviour is that every "resolve()" call will create =
a
> new Executor Pool with number of CPU Cores as size. This is not very
> efficient.
> In my opinion this is unexpected behaviour by Felix, but fortunately we c=
an
> use other constructors.
>
> I left in my PR the default behaviour, but added a new one, which can
> re-use a bounded or unbounded ThreadPoolExecutor. I did not use a
> FixedThreadPool because i wanted to mimic the current behaviour, which is=
:
> After the resolve call, these Threads are gone again.
>
> What do you guys think? Should we change the current "implicit default" t=
o
> re-use a Thread Pool?
> Is a ThreadPoolExecutor with timeout fine to mimic the current behaviour,
> or would we want to change this, lets say to have a dedicated thread pool
> always available for Felix Resolve calls? (This would then be like
> Executors.newFixedThreadPool())
>
> I am trying to get this change into karaf 4.0.8.
>
> Fabian
>
>
> --
> Fabian Lange | Performance Expert
> mobil: +49 (0) 160.3673393
>
> codecentric AG | Merscheider Stra=C3=9Fe 1 | 42699 Solingen | Deutschland
>
> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
> Vorstand: Michael Hochg=C3=BCrtel . Mirko Novakovic . Rainer Vehns
> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus J=C3=A4ger . J=C3=
=BCrgen Sch=C3=BCtz
>


--=20
Karl Pauls
karlpauls@gmail.com

--047d7b5d24b69814b9053dfc6d60--