felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FELIX-5371) ComponentDescriptorIO.java relies on XML tags order
Date Sun, 09 Oct 2016 14:14:20 GMT

     [ https://issues.apache.org/jira/browse/FELIX-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Carsten Ziegeler updated FELIX-5371:
------------------------------------
    Fix Version/s: scr bnd plugin 1.6.0
                   scr generator 1.15.0
                   scr ant task 1.16.0
                   maven-scr-plugin 1.23.0

> ComponentDescriptorIO.java relies on XML tags order
> ---------------------------------------------------
>
>                 Key: FELIX-5371
>                 URL: https://issues.apache.org/jira/browse/FELIX-5371
>             Project: Felix
>          Issue Type: Bug
>          Components: SCR Tooling
>    Affects Versions: scr generator 1.14.0
>            Reporter: Sergey Bondarenko
>            Priority: Critical
>             Fix For: maven-scr-plugin 1.23.0, scr ant task 1.16.0, scr generator 1.15.0,
scr bnd plugin 1.6.0
>
>
> The parser relies implicitly on an order of tags in a component descriptor XML.
> https://github.com/apache/felix/blob/1efe76fff7f4dcc5da5aa450ee8e7a774c874256/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java#L546
> {code}
>                 } else if (localName.equals(IMPLEMENTATION)) {
>                     ...
>                     this.currentClass = new ClassDescription(cl, "classpath:" + className);
>                     ...
>                 } else if (localName.equals(SERVICE)) {
>                     this.currentService = new ServiceDescription(null);
>                     this.currentClass.add(this.currentService);
> {code}
> This chunk of code expects <implementation> tag to happen before <service>
tag. If the order is reversed, then parsing files with NullPointerException when trying to
call "add" on an uninitialized variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message