felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Derek Baum (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5349) add ManagedServiceFactory to HTTP service
Date Fri, 16 Sep 2016 07:30:20 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495640#comment-15495640
] 

Derek Baum commented on FELIX-5349:
-----------------------------------

I was just trying to keep the existing Activator behaviour, but yes, it should shutdown all
instances when the bundle is stopped. 

And I think you're right about needing synchronisation.

BTW, when testing this I was using configadmin 1.8.8, which didn't contain the fix for FELIX-5088
- CaseSensitiveDictionary should implement equals(). This caused JettyConfig.update(Dictionary
props) to think that the props had not changed. It works fine with configadmin-1.8.10.

> add ManagedServiceFactory to HTTP service
> -----------------------------------------
>
>                 Key: FELIX-5349
>                 URL: https://issues.apache.org/jira/browse/FELIX-5349
>             Project: Felix
>          Issue Type: New Feature
>          Components: HTTP Service
>    Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>            Reporter: Derek Baum
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: http.base-3.0.14, http.jetty-3.2.6
>
>         Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a ManagedServiceFactory
and so were others as indicated in this stack overflow conversation: http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP service myself.
It is difficult to do externally to the http.jetty bundle, as it requires access to internal
packages.
> I have therefore created a small patch to revision 1760954 which adds a ManagedServiceFactory,
without changing any of the existing functionality of the ManagedService. This allows multiple
http.jetty instances to be configured using WebConsole, fileinstall or other config admin
clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes it easier
to target a specific HTTP whiteboard service than filtering on the port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message