felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5269) ConfigAdmin Web Console plugin does not display ConfigurationException messages from DS methods
Date Sun, 29 May 2016 08:05:12 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305819#comment-15305819

David Jencks commented on FELIX-5269:

The config _is_ saved, as far as config admin is concerned there is no problem with it.  I
don't see how something monitoring config admin can possibly see an exception from a different
system and recognize it.  For instance, the configuration event is delivered to DS on a separate
thread than the web console plugin changes the configuration in.  How would the plugin recognize
which thread was delivering the config event so know that it was related to the configuration
change?  What do you expect to happen if you first install your configuration, and then sometime
later your DS component?

> ConfigAdmin Web Console plugin does not display ConfigurationException messages from
DS methods
> -----------------------------------------------------------------------------------------------
>                 Key: FELIX-5269
>                 URL: https://issues.apache.org/jira/browse/FELIX-5269
>             Project: Felix
>          Issue Type: Bug
>          Components: Configuration Admin
>    Affects Versions: configadmin-1.8.8
>         Environment: Declarative Services with Metatype annotations
>            Reporter: Matt Bishop
>            Priority: Minor
> A bit of setup:
> 1. A Component has methods annotated with DS @Activate/@Modified and takes an @interface-style
configuration object. Looks like this:
> @Modified
> public void modified(MyConfig config) throws ConfigurationException {
>     if (messedUp(config.thing())) {
>         throw new ConfigurationException("thing", "thing is messed up.");
>     }
>     //carry on with configuration
> }
> 2. User opens up Config Admin web console and sees a nice UI to edit 'thing' field for
this component. They edit the field in a way that will trigger the ConfigurationException
and then 'save' the config.
> Expected:
>   Web Console UI shows a failure message, and possibly highlights 'thing' to direct attention
to the offending field.
> Actual:
>   Nothing really. Web Console looks like the config is saved.
> One note, the exception is logged out. 

This message was sent by Atlassian JIRA

View raw message