felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FELIX-4848) Split ResolverImpl
Date Wed, 11 May 2016 07:30:13 GMT

     [ https://issues.apache.org/jira/browse/FELIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christian Schneider closed FELIX-4848.
--------------------------------------
    Resolution: Won't Fix

It is indeed a bit frustrating .. I will keep at it though. I think it is best to close this
issue and create new ones for additional improvements. I have identified some additional changes
and will propose them in a mail. For example I think the idea of extracting ConsistencyCheck
still could make sense. 

> Split ResolverImpl
> ------------------
>
>                 Key: FELIX-4848
>                 URL: https://issues.apache.org/jira/browse/FELIX-4848
>             Project: Felix
>          Issue Type: Improvement
>          Components: Resolver
>    Affects Versions: resolver-1.0.0
>            Reporter: Christian Schneider
>             Fix For: resolver-2.0.0
>
>         Attachments: Dependencies in resolver package after patch.png, FELIX-4848-1.patch
>
>
> ResolverImpl currently contains about 2300 lines of code. That is way too big for a single
class.
> I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency
methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.
> Both would share all of the inner classes of ResolverImpl but nothing else. 
> So I think i would make sense to move these inner classes to separate files.
> These changes should nicely split the classes into 
> ResolverImpl : 1400 lines
> ConsistencyCheck : 600 lines



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message