felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Seifert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
Date Thu, 14 Apr 2016 13:58:25 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241197#comment-15241197
] 

Stefan Seifert commented on FELIX-4009:
---------------------------------------

can we apply the changes from my 2nd pull request as well (see previous comment)?

they are together with the first PR quite un-intrusive, so for users who do not use osgi mocks
and do not care about incremental build support in eclipse not much should change (because
only the manifest goal is instrumented to be used in eclipse, which osgi mock users should
configure in their poms).

if we do not want to apply it because the full solution is not perfect due to external constraints
(see previous comment) we should revert the changes from my first PR on the code base. what's
currently applied without the second PR is unstable.

> maven bundle plugin should be integrated directly with eclipse
> --------------------------------------------------------------
>
>                 Key: FELIX-4009
>                 URL: https://issues.apache.org/jira/browse/FELIX-4009
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.3.7
>            Reporter: Andrei Pozolotin
>            Assignee: Carsten Ziegeler
>              Labels: m2e
>             Fix For: maven-bundle-plugin-3.0.2
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must  use tycho configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with eclipse
via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin
> thanks.
> Andrei.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message