Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5C19188A3 for ; Mon, 8 Feb 2016 18:01:40 +0000 (UTC) Received: (qmail 40648 invoked by uid 500); 8 Feb 2016 18:01:40 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 40503 invoked by uid 500); 8 Feb 2016 18:01:40 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 40360 invoked by uid 99); 8 Feb 2016 18:01:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Feb 2016 18:01:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 005712C1F6C for ; Mon, 8 Feb 2016 18:01:40 +0000 (UTC) Date: Mon, 8 Feb 2016 18:01:40 +0000 (UTC) From: "Quinn Stevenson (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-5179) maven-bundle-plugin incorrectly handles Bundle-Blueprint instruction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137364#comment-15137364 ] Quinn Stevenson commented on FELIX-5179: ---------------------------------------- I attached at patch that fixes enough of the problem that I can proceed. With the patch, the plugin will correctly interrogate slash-terminated directory entries by removing the trailing slash before it looks for directory. The patch also disables the re-write of the Bundle-Blueprint header in the MANIFEST.MF - the value specified in the POM is used if present. If no value is specified in the POM, the Bundle-Blueprint value isn't written in the MANIFEST.MF, and the default for the platform will be used. > maven-bundle-plugin incorrectly handles Bundle-Blueprint instruction > -------------------------------------------------------------------- > > Key: FELIX-5179 > URL: https://issues.apache.org/jira/browse/FELIX-5179 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin > Reporter: Quinn Stevenson > Attachments: FELIX_5179.patch > > > When the instruction is specified, it cannot handle the formats specified by the OSGi Blueprint specification. Further, when the plugin incorrectly interprets the value of the instruction, it removes it from the resulting manifest. > Examples of specification issues: > - The specification states that directories should be terminated with a '/' character. If you do this in the Bundle-Blueprint instruction, the plugin won't find the directory, it won't process any of the Blueprint XML files in any directory, and it won't put the Bundle-Blueprint header in the MANIFEST.MF. > - The specification allows for wildcard in the last portion of the entry - things like *.xml. If you put a wildcard in the Bundle-Blueprint instruction, it behaves the same way as if the trailing '/' is appended to a directory name. > Also, the plugin re-writes the Bundle-Blueprint header to include all of the blueprint XML files it finds. I think the plugin should leave the value alone if it is specified. This re-write behavior is breaking my OSGi Fragment bundles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)