felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5176) [DS] Make gogo command more likely to show info from annotations in shell
Date Wed, 03 Feb 2016 01:36:39 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129569#comment-15129569

David Jencks commented on FELIX-5176:

Tom Watson pointed out a fatal defect in this approach, namely that if the gogo shell is installed
and ds wires to it to make the annotations on the command available, and then the gogo shell
is uninstalled, that's going to require DS to refresh to get rid of the broken wire (or gogo
will hang around unwanted and unloved and the annotations won't work when gogo is reinstalled).
 So alternatives are (1) checking that having the annotations as private-package and not imported
doesn't work (I can't imagine it would) (2) making a way so gogo can get the info off of service
properties rather than annotations or (3) putting the gogo command in a separate bundle with
mandatory import for the annotation package.

> [DS] Make gogo command more likely to show info from annotations in shell
> -------------------------------------------------------------------------
>                 Key: FELIX-5176
>                 URL: https://issues.apache.org/jira/browse/FELIX-5176
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-2.0.2
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-2.0.4
> Right now the gogo annotations have to be present at scr startup in order to be used
so the extra info shows up in the gogo shell (import is optional).  Using ServiceFactory for
the gogo command (and shell command) and changing the import to dynamic lets the annotations
show up later and still get used.  This depends on only the gogo shell fetching the gogo command,
which is not that much of a restriction....

This message was sent by Atlassian JIRA

View raw message