felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "J.W. Janssen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FELIX-4375) Error when reading gosh_profile from stream
Date Tue, 19 Jan 2016 13:50:39 GMT

     [ https://issues.apache.org/jira/browse/FELIX-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

J.W. Janssen resolved FELIX-4375.
---------------------------------
    Resolution: Fixed

Applied a slightly different version of your proposed patch in rev #1725519.

> Error when reading gosh_profile from stream
> -------------------------------------------
>
>                 Key: FELIX-4375
>                 URL: https://issues.apache.org/jira/browse/FELIX-4375
>             Project: Felix
>          Issue Type: Bug
>          Components: Gogo Shell
>    Affects Versions: gogo.shell-0.10.0
>         Environment: Error occurred using Gogo shell on top op Concierge OSGi runtime.
>            Reporter: Tim Verbelen
>            Priority: Minor
>
> An error occurs when "gosh_profile" is read from a stream without knowing the lenght
upfront. In that case, method `CharSequence readScript(URI script)` from `Shell.java` causes
an error, since it does not correctly handle the case when the length is -1. In that case,
a large size buffer is allocated (fixed on 10240 atm), and thus as the buffer will not be
completely filled, one cannot use `cbuf.rewind()`, but use `cbuf.flip()` instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message