felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "munene kiruja (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FELIX-5111) Persistence Manager complete support for comments
Date Fri, 20 Nov 2015 19:31:11 GMT

     [ https://issues.apache.org/jira/browse/FELIX-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

munene kiruja updated FELIX-5111:
    Attachment: ConfigInstallerTest.java

The attached files contain changes offering an implementation to meet the above requirements.
The GEConfigurationHandler is a modified copy of the ConfigurationHandler class in apache.felix.configadmin.file
that is imported at the source level by the fileinstall project. Putting the changes here
keeps everything in one spot. Accepter can opt to add them to configadmin.

> Persistence Manager complete support for comments
> -------------------------------------------------
>                 Key: FELIX-5111
>                 URL: https://issues.apache.org/jira/browse/FELIX-5111
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: fileinstall-3.5.0
>            Reporter: munene kiruja
>         Attachments: ConfigInstaller.java, ConfigInstallerTest.java, GEConfigurationHandler.java
> Felix Fileinstall 3.5.0 added support for .config files with an elaborate format for
type specification and also support for arrays (and collections).
> However it did not support comments but would choke on them, combining comments with
the configuration data and corrupting the configuration file. Also the .config files are sorted
alphabetically, possibly altering the original order.
> https://issues.apache.org/jira/browse/FELIX-4917 was created and a change submitted that
was accepted, that allows the comments to be skipped over, but when the config is written
back, the comments are lost. The sorting also still takes place.
> Comments are a vital part of the user interface, communicating information about how
to customize the OSGi services. To maintain equivalent functionality with the .cfg format,
the following are necessary:
> - reading the .config file should be able to skip the comments
> - writing the .config file back should retain the comments and the structuer of the .config
> - updating should modify in the update map, leaving any in file but missing in the update
set intact
> - updating should add any values in update set but absent in the file

This message was sent by Atlassian JIRA

View raw message